Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please Adding CW20 Token From Garuda Universe Ecosystem Terra Classic #31

Merged
merged 21 commits into from
Mar 30, 2024
Merged

Please Adding CW20 Token From Garuda Universe Ecosystem Terra Classic #31

merged 21 commits into from
Mar 30, 2024

Conversation

garudawork
Copy link
Contributor

No description provided.

@garudawork
Copy link
Contributor Author

hi @HeesungB maybe you can update node.js so our contact can be
validate

@HeesungB
Copy link
Collaborator

@garudawork Hello.
I think it's the case of the token name, can you check?

Fetched metadata is not same with the token metadata: (
expected: {"name":"GARUDAX TOKEN","symbol":"GRDX","decimals":6}, 
actual: {"name":"GarudaX Token","symbol":"GRDX","decimals":6}), 
contract: terra12f3f5fzfzxckc0qlv3rmwwkjfhzevpwmx77345n0zuu2678vxf0sm6vvcw, chain: columbus)

@garudawork
Copy link
Contributor Author

Thank you for the reply sir i will double check it

@HeesungB
Copy link
Collaborator

@garudawork Could you add image below link?
https://github.com/chainapsis/keplr-contract-registry/tree/main/images

HeesungB
HeesungB reviewed Mar 28, 2024
View reviewed changes
cosmos/columbus/tokens/terra12f3f5fzfzxckc0qlv3rmwwkjfhzevpwmx77345n0zuu2678vxf0sm6vvcw.json Outdated
@@ -0,0 +1,9 @@
{
"contractAddress": "terra12f3f5fzfzxckc0qlv3rmwwkjfhzevpwmx77345n0zuu2678vxf0sm6vvcw",
"imageUrl": "https://raw.githubusercontent.com/chainapsis/keplr-contract-registry/020d747f32130bca706ef79e6dd84e2adf1957f7/images/columbus/GARUDAX%20TOKEN.png",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garudawork Could you rename image as symbol?

HeesungB
HeesungB reviewed Mar 28, 2024
View reviewed changes
cosmos/columbus/tokens/terra12f3f5fzfzxckc0qlv3rmwwkjfhzevpwmx77345n0zuu2678vxf0sm6vvcw.json Outdated
@@ -0,0 +1,9 @@
{
"contractAddress": "terra12f3f5fzfzxckc0qlv3rmwwkjfhzevpwmx77345n0zuu2678vxf0sm6vvcw",
"imageUrl": "https://raw.githubusercontent.com/chainapsis/keplr-contract-registry/7ec7c4fa3d07691f0af8ad6f5e54f61aaffdf4e0/images/columbus/GARUDAX.png",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garudawork Could you double check about imageUrl?

The path is different
https://raw.githubusercontent.com/chainapsis/keplr-contract-registry/7ec7c4fa3d07691f0af8ad6f5e54f61aaffdf4e0/images/columbus/GARUDAX.png

You should be like below.
https://raw.githubusercontent.com/chainapsis/keplr-contract-registry/main/images/columbus/GARUDAX.png

@garudawork
Copy link
Contributor Author

is something still wrong?

HeesungB
HeesungB reviewed Mar 28, 2024
View reviewed changes
cosmos/columbus/tokens/terra12f3f5fzfzxckc0qlv3rmwwkjfhzevpwmx77345n0zuu2678vxf0sm6vvcw.json Outdated
@@ -0,0 +1,9 @@
{
"contractAddress": "terra12f3f5fzfzxckc0qlv3rmwwkjfhzevpwmx77345n0zuu2678vxf0sm6vvcw",
"imageUrl": "https://raw.githubusercontent.com/garudawork/keplr-contract-registry/main/images/columbus/GARUDAX.png",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garudawork Could you change repository name of imageUrl?

https://raw.githubusercontent.com/garudawork-> https://raw.githubusercontent.com/chainapsis

@HeesungB
Copy link
Collaborator

@garudawork Could you resize image to 512x512px?

Reduce image size to 512x512 or smaller (expected: 512x512, actual: 925x926)

@HeesungB HeesungB merged commit 66d01dc into chainapsis:main Mar 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeesungB HeesungB HeesungB left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garudawork @HeesungB